[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

issue 5319: Make skylines reflect grob rotation (issue 342060043 by addr

From: torsten . haemmerle
Subject: issue 5319: Make skylines reflect grob rotation (issue 342060043 by address@hidden)
Date: Thu, 03 May 2018 05:51:11 -0700

Reviewers: ,

Please review...

Inadvertently, file
slipped into the patch (from issue 5312 currently in staging).

So ignore is (or shall I upload a new, cleansed patch for reviewing?)


issue 5319: Make skylines reflect grob rotation

modified:   ../lily/include/stencil.hh
Add parameter to skylines_from_stencil for rot (in analogy to pad)

modified:   ../lily/

If new rotation parameter rot is specified, use a rotated copy of
the original stencil to build the skyline transformation matrix.
As the rotation is rarely used, the general (non-rotated) case will
still use the original stencil as before.

Grob::vertical_sklyines_from_grob and
Read "rotation" property an pass it (SCM) to skylines_from_stencil.

modified:   ../lily/

Read "rotation" property and pass it (SCM) to skylines_from_stencil.

Announced in ../Documentation/changes.tely

Documentation example slightly adapted (20° to 15°) to new skyline
behaviour (padding will now be respected). In all affected languages:
modified:   ../Documentation/de/notation/changing-defaults.itely
modified:   ../Documentation/es/notation/changing-defaults.itely
modified:   ../Documentation/fr/notation/changing-defaults.itely
modified:   ../Documentation/it/notation/changing-defaults.itely
modified:   ../Documentation/ja/notation/changing-defaults.itely
modified:   ../Documentation/notation/changing-defaults.itely

modified:   ../input/regression/
(20° to 15°, cf. documentation)

new:   ../input/regression/
New regression test.

Please review this at

Affected files (+109, -25 lines):
  M Documentation/changes.tely
  M Documentation/de/notation/changing-defaults.itely
  M Documentation/es/notation/changing-defaults.itely
  M Documentation/fr/notation/changing-defaults.itely
  M Documentation/it/notation/changing-defaults.itely
  M Documentation/ja/notation/changing-defaults.itely
  M Documentation/notation/changing-defaults.itely
  A input/regression/
  M input/regression/
  M lily/
  M lily/include/stencil.hh
  M lily/
  M lily/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]