[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Use convert -strip (issue 339350043 by address@hidden)

From: bmwiedemann
Subject: Re: Use convert -strip (issue 339350043 by address@hidden)
Date: Sun, 03 Jun 2018 06:04:40 -0700

Reviewers: dulow kotic, lilypond-pkx, Dan Eble,

On 2018/06/02 19:29:16, Dan Eble wrote:
File Documentation/pictures/GNUmakefile (right):
Documentation/pictures/GNUmakefile:29: convert -strip -depth 8
-geometry 50x50%
$< $@
It would be wise to add a brief comment before the dependency line
why -strip is important, otherwise someone might come along later,
decide that
it is pointless, and remove it.

Are there any undesirable side effects of -strip, for example,
removing a
copyright notice?  The man page says that -strip "strip[s the] image
of all
profiles and comments" but I'm not familiar enough with convert to
know what
that means.  Are profiles also unimportant here?

Not sure why the tools didnt show it, but this was handled in
and merged as commit d1d5f436a190929e38145cf8be7d4fa63b077b46

IMHO, git blame is usually a good tool to find out on why something was

and I don't think -strip removes important information in this case.

Use convert -strip

to not add timestamps to .png output files
to make build reproducible

See for why this is good.

Without this patch, files in the openSUSE lilypond-doc package would
differ for every build:

Please review this at

Affected files (+2, -2 lines):
  M Documentation/pictures/GNUmakefile

Index: Documentation/pictures/GNUmakefile
diff --git a/Documentation/pictures/GNUmakefile b/Documentation/pictures/GNUmakefile index 8f53363046bfa0ee0a161d9b2dfdfe8bdacd2120..2b5ae3796f5d781fc8cc323a81e4b98434ea9693 100644
--- a/Documentation/pictures/GNUmakefile
+++ b/Documentation/pictures/GNUmakefile
@@ -26,10 +26,10 @@ endif
 ### Rules

 $(outdir)/%-flat-gray.png: %-flat-gray.png
-       convert -depth 8 -geometry 50x50% $< $@
+       convert -strip -depth 8 -geometry 50x50% $< $@

 $(outdir)/%-flat-bw.png: %-flat-bw.png
-       convert -depth 8 -geometry 50x50% $< $@
+       convert -strip -depth 8 -geometry 50x50% $< $@

 $(outdir)/%.png: $(top-src-dir)/Documentation/pictures/%.png
        $(LN_SRC_TO_BUILD) -f $< $@

reply via email to

[Prev in Thread] Current Thread [Next in Thread]