[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix out-of-sync LilyScriptEncoding / ps script defs (issue 347870043
|
From: |
knupero |
|
Subject: |
Re: Fix out-of-sync LilyScriptEncoding / ps script defs (issue 347870043 by address@hidden) |
|
Date: |
Fri, 08 Jun 2018 03:33:09 -0700 |
On 2018/06/08 10:29:40, dak wrote:
On 2018/06/08 09:54:29, knupero wrote:
> Please review.
When you say "will not pass make check", you mean that there are
visual
differences, not that the test aborts, right? Since the latter would
not be ok.
Exactly. There is an intended visual difference, but 'make test' runs
fine.
https://codereview.appspot.com/347870043/