Re: issue #5341: Urgent corrections to stencil-integral.cc (skylines) (issue 341350043 by address@hidden)

[dak]

On 2018/06/12 10:49:11, Be-3 wrote:
> On 2018/06/12 10:05:17, dak wrote:
> > However, cough cough, all this is an unnecessary complication.
Sorry for
> > overlooking this.  Just write
> >
> > Stencil q = *s;
> > […]

> Just to mention it:
> How about the definition of ly:stencil-rotate in
lily/stencil-scheme.cc?
> There, we should have the exact same problem, shouldn't we?

No.  new_s is the return value so the compiler cannot possibly optimize
it away.

https://codereview.appspot.com/341350043/