[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Remove Moment::as_scheme (issue 346070043 by address@hidden)
From: |
dak |
Subject: |
Re: Remove Moment::as_scheme (issue 346070043 by address@hidden) |
Date: |
Wed, 13 Jun 2018 14:25:44 -0700 |
Reviewers: Dan Eble,
Message:
On 2018/06/13 21:11:38, Dan Eble wrote:
LGTM and I would not fault you if you chose to push this immediately
after
receiving independent confirmation that it builds.
Shrug. I have no dependencies on this one. It can sit in its branch
until the shoe drops. I just found it when using Moment as a sort of
template for a new Transform class and dug around finding what it's even
being used for.
Description:
Remove Moment::as_scheme
It's a remnant of some design long abandoned.
Please review this at https://codereview.appspot.com/346070043/
Affected files (+1, -14 lines):
M lily/include/moment.hh
M lily/moment.cc
Index: lily/include/moment.hh
diff --git a/lily/include/moment.hh b/lily/include/moment.hh
index
c29032f99dc6f56d32fc087b2dcecfaccda7fe16..8a6136eb2870a430da3584363cf912a8b21f99ab
100644
--- a/lily/include/moment.hh
+++ b/lily/include/moment.hh
@@ -56,12 +56,9 @@ public:
bool to_bool () const;
I64 den () const;
I64 num () const;
- /*
- Deliver a copy of THIS as a smobified SCM
- */
+
string to_string () const;
static int compare (Moment const &, Moment const &);
- SCM as_scheme () const;
};
IMPLEMENT_ARITHMETIC_OPERATOR (Moment, +);
Index: lily/moment.cc
diff --git a/lily/moment.cc b/lily/moment.cc
index
20c1f58a0b51cdef2e0c5e42e16c4dced7014e7d..d05fafc9e3755fe01a73e4ea34c70eedf0d360b1
100644
--- a/lily/moment.cc
+++ b/lily/moment.cc
@@ -58,16 +58,6 @@ Moment::print_smob (SCM port, scm_print_state *) const
return 1;
}
-SCM
-Moment::as_scheme () const
-{
- return scm_list_5 (ly_symbol2scm ("ly:make-moment"),
- scm_from_int64 (main_part_.num ()),
- scm_from_int64 (main_part_.den ()),
- scm_from_int64 (grace_part_.num ()),
- scm_from_int64 (grace_part_.den ()));
-}
-
SCM
Moment::equal_p (SCM a, SCM b)
{