[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fingering-engraver.cc: don't set Fingering.pitch (issue 347930043 by
Re: fingering-engraver.cc: don't set Fingering.pitch (issue 347930043 by address@hidden)
Thu, 02 Aug 2018 23:52:29 -0700
On 2018/08/03 03:24:40, lemzwerg wrote:
LGTM. I suggest that you do such trivial clean-ups directly in the
repository, not wasting your time with setting up an issue.
If Han-Wen did not see fit to remove the line but instead went to the
trouble of adding a "WTF?" comment, I think removing without an
opportunity for people to check would be optimistic. Also I leave a
record that way.
fingering-engraver.cc: don't set Fingering.pitch
This grob property does not actually exist.
Please review this at https://codereview.appspot.com/347930043/
Affected files (+0, -9 lines):
diff --git a/lily/fingering-engraver.cc b/lily/fingering-engraver.cc
@@ -94,15 +94,6 @@ Fingering_engraver::make_script (Direction d,
Stream_event *r, int i)
Item *fingering = make_item ("Fingering", r->self_scm ());
- Huh, what's this for? --hwn.
- SCM pitch = r->get_property ("pitch");
- if (unsmob<Pitch> (pitch))
- fingering->set_property ("pitch", pitch);
We can't fold these definitions into define-grobs since
fingerings for chords need different settings.
- Re: fingering-engraver.cc: don't set Fingering.pitch (issue 347930043 by address@hidden),