[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by add

From: paulwmorris
Subject: Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by address@hidden)
Date: Sat, 10 Nov 2018 11:44:47 -0800

Hi Charles, Today I built and ran 'make check' with your patch applied
to current master.  I was able to get it to pass 'make check' by making
the following two changes.

1. In `chord-entry.scm` line 267, remove `(write-me "base3: " bass)`.

2. In that same file, line 100, remove the parens to change
`(chord-semantics)` to just `chord-semantics`.

The first change fixed this error (but note the type check warning):


Renaming input to:
warning: type check for `bass' failed; value `(#t . #t)' must be of type
In procedure memoization in expression (if ba
ss (write-me "base3: " bass) ...):
In file "/home/james/lilypond-git/build/out/s
hare/lilypond/current/scm/chord-entry.scm", line 266: Missing or extra
expression in (if bass (write-me "base3: " bass) (list (make
-note-ev bass (quote bass) #t)) (quote ())).

And the second change fixed this error:


$ /home/dev/lilypond-git/build/out/bin/lilypond
GNU LilyPond 2.21.0
Processing `input/regression/'
In expression (chord-semantics):
Wrong type to apply: ((modifier . #f) (root . #<Pitch c' >) (extension .
7) (additions) (removals) (bass . #f))

So if you have a chance to upload a new patch set with those two
changes, that should get things moving forward with the code review


reply via email to

[Prev in Thread] Current Thread [Next in Thread]