lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Improve markup->string (issue 347000043 by address@hidden)


From: thomasmorley65
Subject: Re: Improve markup->string (issue 347000043 by address@hidden)
Date: Sun, 11 Nov 2018 07:57:41 -0800

Hi Paul,

thanks for review


https://codereview.appspot.com/347000043/diff/40001/scm/markup.scm
File scm/markup.scm (right):

https://codereview.appspot.com/347000043/diff/40001/scm/markup.scm#newcode141
scm/markup.scm:141: ;; The string is split at line-breaks, emty strings
removed and finally
On 2018/11/11 15:43:37, pwm wrote:
typo: empty

Done.

https://codereview.appspot.com/347000043/diff/40001/scm/markup.scm#newcode148
scm/markup.scm:148: simple-markup)))
On 2018/11/11 15:43:37, pwm wrote:
Indent 'list' expression so it is clearer that it is the second
argument to
'member' and not another 'and' expression.

Done.

https://codereview.appspot.com/347000043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]