[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fixx #3314 : use superscript for powerChordSymbol (issue 348060043 b

From: v . villenave
Subject: Re: Fixx #3314 : use superscript for powerChordSymbol (issue 348060043 by address@hidden)
Date: Thu, 13 Dec 2018 04:26:07 -0800

Reviewers: dak,
File ly/ (right):
ly/ <c g>1-\markup { \super "5" }
On 2018/12/13 11:32:34, dak wrote:
The way this is arranged currently, it reads jarringly.

I agree, there are a few things that look quite bad: among others,
\partialJazzMusic should be rewritten (and its use is hardly
documented); there’s a TODO line 534 in chord.itely that should be
addressed; Documentation/included/ should be entirely
rewritten by taking advantage of predefined exception lists rather than
duplicating lots of stuff; "banter-chord-names" isn’t documented
anywhere and looks deprecated anyway; and there are a bunch of regtests
that have been scrapped over the years.

Since I don’t know much about all of these and was reluctant to open
that particular can of worms, I was merely aiming for the low-hanging
fruits here :-)

Fixx #3314 : use superscript for powerChordSymbol

There doesn’t appear to be any reason why normal-size-super
was used in the first place, unlike in other chords.

Please review this at

Affected files (+2, -2 lines):
  M ly/

Index: ly/
diff --git a/ly/ b/ly/
index 4f7483fc99c42fff8c1d0bff872fd56cf8c6ea0a..72b99a33fa72cb1481455b29cffcc5a31d9aaa4b 100644
--- a/ly/
+++ b/ly/
@@ -46,8 +46,8 @@ partialJazzMusic = {

 powerChordSymbol = {
-  <c g>-\markup { \normal-size-super "5" }
-  <c g c'>1-\markup { \normal-size-super "5" }
+  <c g>1-\markup { \super "5" }
+  <c g c'>-\markup { \super "5" }

reply via email to

[Prev in Thread] Current Thread [Next in Thread]