Re: Fixx #3314 : use superscript for powerChordSymbol (issue 348060043 by address@hidden)

[v . villenave]

Reviewers: dak,


https://codereview.appspot.com/348060043/diff/1/ly/chord-modifiers-init.ly
File ly/chord-modifiers-init.ly (right):

https://codereview.appspot.com/348060043/diff/1/ly/chord-modifiers-init.ly#newcode49
ly/chord-modifiers-init.ly:49: <c g>1-\markup { \super "5" }
On 2018/12/13 11:32:34, dak wrote:
> The way this is arranged currently, it reads jarringly.

I agree, there are a few things that look quite bad: among others,
\partialJazzMusic should be rewritten (and its use is hardly
documented); there’s a TODO line 534 in chord.itely that should be
addressed; Documentation/included/chord-names-jazz.ly should be entirely
rewritten by taking advantage of predefined exception lists rather than
duplicating lots of stuff; "banter-chord-names" isn’t documented
anywhere and looks deprecated anyway; and there are a bunch of regtests
that have been scrapped over the years.

Since I don’t know much about all of these and was reluctant to open
that particular can of worms, I was merely aiming for the low-hanging
fruits here :-)

Description:
Fixx #3314 : use superscript for powerChordSymbol

There doesn’t appear to be any reason why normal-size-super
was used in the first place, unlike in other chords.

Please review this at https://codereview.appspot.com/348060043/

Affected files (+2, -2 lines):
  M ly/chord-modifiers-init.ly


Index: ly/chord-modifiers-init.ly
diff --git a/ly/chord-modifiers-init.ly b/ly/chord-modifiers-init.ly
index  
4f7483fc99c42fff8c1d0bff872fd56cf8c6ea0a..72b99a33fa72cb1481455b29cffcc5a31d9aaa4b  
100644
--- a/ly/chord-modifiers-init.ly
+++ b/ly/chord-modifiers-init.ly
@@ -46,8 +46,8 @@ partialJazzMusic = {
 }

 powerChordSymbol = {
-  <c g>-\markup { \normal-size-super "5" }
-  <c g c'>1-\markup { \normal-size-super "5" }
+  <c g>1-\markup { \super "5" }
+  <c g c'>-\markup { \super "5" }
 }