[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Issue 5251/1: set default restNumberThreshold = 1 (issue 353850043 by ad

From: thomasmorley65
Subject: Issue 5251/1: set default restNumberThreshold = 1 (issue 353850043 by address@hidden)
Date: Thu, 27 Dec 2018 04:56:57 -0800

Hi Malte,

some concerns:
File Documentation/notation/rhythms.itely (right):
I tried to test your patch, but 'make' failed with error: file not found:
I had to exclude this lines to finish 'make'

Is there the _need_ to import lsr first?
If so, I think it should be part of the current patch in an own commit.
Imho, it's good practise to have every issue's patch-set being able to
stand alone.
File Documentation/snippets/new/
\relative {
no need for \relative here

Meanwhile I've approved this snippet in LSR (deleting \relative). So I
don't think there is any need to put it in Documentation/snippets/new as
It will be available after next lsr-import anyway.
File lily/ (right):
lily/ int t = scm_to_int (thres);
I don't think this is the correct way.

We want a fall-back-value if restNumberThreshold is unset. Only setting
it in is not sufficient, imho, because setting
context-properties will not create a reversible stack. Thus this example
\relative {
  \set restNumberThreshold = 0
  R1 R1*2
  \unset restNumberThreshold
  R1 R1*2
ERROR: Wrong type (expecting exact integer): ()
Leaving the user perplexed what he might have done.

Not sure if the old coding is the best way o provide such a fall-back,
my C++-knowledge is close to zero, so I can't come up with a better

reply via email to

[Prev in Thread] Current Thread [Next in Thread]