Re: Issue 5251/1: set default restNumberThreshold = 1 (issue 353850043 by address@hidden)

[thomasmorley65]

https://codereview.appspot.com/353850043/diff/1/Documentation/snippets/new/numbering-single-measure-rests.ly
File Documentation/snippets/new/numbering-single-measure-rests.ly
(right):

https://codereview.appspot.com/353850043/diff/1/Documentation/snippets/new/numbering-single-measure-rests.ly#newcode14
Documentation/snippets/new/numbering-single-measure-rests.ly:14:
\relative {
On 2018/12/27 14:35:18, Malte Meyn wrote:
> On 2018/12/27 12:56:57, thomasmorley651 wrote:
> > no need for \relative here

> Oh, of course you’re right, I’ll change that.

> > Meanwhile I've approved this snippet in LSR (deleting \relative). So
I don't
> > think there is any need to put it in Documentation/snippets/new as
well.
> > It will be available after next lsr-import anyway.

> I can’t find the snippet using the search function; why?

You mean in LSR?
New approved snippets are usually available with a day delay. I'd try
tomorrow.

Because 'numbering-single-measure-rests.ly' is compilable with 2.18. you
probably can omit it here entirely, if you run make-lsr.
Not sure, though. Please check.


> I followed James’s directions

(https://lists.gnu.org/archive/html/lilypond-devel/2018-12/msg00153.html),
> that’s why I didn’t do the makelsr.py run.

I'd do so to warrant stand-alone compilation-ability of this patch-set.
But that's only me.
Others?

https://codereview.appspot.com/353850043/diff/1/ly/engraver-init.ly
File ly/engraver-init.ly (right):

https://codereview.appspot.com/353850043/diff/1/ly/engraver-init.ly#newcode272
ly/engraver-init.ly:272: restNumberThreshold = 1
On 2018/12/27 14:35:18, Malte Meyn wrote:
> Should we keep this even if we have a default value in
> multi-measure-rest-engraver.cc? IMHO: yes, because then it will be
listed in the
> IR.

I tend to agree.

https://codereview.appspot.com/353850043/