[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Doc: add markup objects overview (issue 357930043 by address@hidden)

From: lemzwerg
Subject: Re: Doc: add markup objects overview (issue 357930043 by address@hidden)
Date: Sun, 20 Jan 2019 22:18:35 -0800

LGTM, with some minor issues.  Thanks!
File Documentation/notation/text.itely (right):
Documentation/notation/text.itely:50: @cindex Text objects
Any specific reason why you use uppercase?  Wouldn't

  @cindex text objects

be sufficient?
Documentation/notation/text.itely:51: @cindex Markup objects
BTW, I think you should also add

  @cindex objects, markup

for completeness.
Grammatical nitpick: If you have a list of items, either do

  This is as follows.
  * Foo bar.
  * Ping pong.
  * Frob nicate.


  This is as follows:
  * foo bar;
  * ping pong;
  * frob nicate.
Documentation/notation/text.itely:82: in any definition inside the
@code{\header} block (e.g.
Mid-sentence abbreviations that end with a full dot should have a
trailing '@:' to get correct whitespace.  In this case, however, I would
write 'e.g.,'
Documentation/notation/text.itely:83: @var{title}, @var{subtitle},
@var{composer}), or in some

Those header block elements are not variable (i.e., they cannot be
changed by the user to an arbitrary string).
Documentation/notation/text.itely:85: @var{evenHeaderMarkup} for page
numbers.  This is explained in
Documentation/notation/text.itely:89: @noindent
I don't see a necessity for '@noindent'.  You actually start a new
paragraph, don't you?
Documentation/notation/text.itely:119: @noindent
Documentation/notation/text.itely:122: @var{text} property if it has
one, or its @var{stencil} property.  Some of
Documentation/notation/text.itely:148: \once \override NoteHead.text =
\markup \lower #0.5 "NoteHead"
Please check the PDF output; I guess that some lines in your example are
too wide.
Documentation/notation/text.itely:641: Extentind LilyPond:

reply via email to

[Prev in Thread] Current Thread [Next in Thread]