Re: Add glib-2.0 and gobject-2.0 library dependency (issue 568820043 by address@hidden)

[pkxgnugitcl]

https://codereview.appspot.com/568820043/diff/582790043/config.make.in
File config.make.in (right):

https://codereview.appspot.com/568820043/diff/582790043/config.make.in#newcode23
config.make.in:23: CONFIG_CFLAGS = @CFLAGS@ $(GLIB_CFLAGS)
$(GUILE_CFLAGS)
On 2019/06/17 07:59:41, knupero wrote:
> This breaks building.

> If you break lines, you need to use ' \'

Ah yes, of course!. Sorry ("it's not just white space James!").

Done.

Although it didn't break the patch test - which would have done a new
'make' after it had been applied (after a make test-baseline had been
done). So I am guessing that the normal Patch Test Workflow does not
work for these files?

https://codereview.appspot.com/568820043/diff/582790043/config.make.in#newcode25
config.make.in:25: CONFIG_CXXFLAGS = @CXXFLAGS@ $(GUILE_CFLAGS)
$(FREETYPE2_CFLAGS)
On 2019/06/17 07:59:41, knupero wrote:
> see above

Done.

https://codereview.appspot.com/568820043/diff/582790043/config.make.in#newcode36
config.make.in:36: CONFIG_LIBS = @LIBS@ @EXTRA_LIBS@ $(GLIB_LIBS)
$(GUILE_LIBS)
On 2019/06/17 07:59:41, knupero wrote:
> see above

Done.

https://codereview.appspot.com/568820043/diff/582790043/config.make.in#newcode37
config.make.in:37: $(PANGO_FT2_LIBS) $(FONTCONFIG_LIBS)
On 2019/06/17 07:59:41, knupero wrote:
> see above

Done.

https://codereview.appspot.com/568820043/diff/582790043/configure.ac
File configure.ac (right):

https://codereview.appspot.com/568820043/diff/582790043/configure.ac#newcode301
configure.ac:301: STEPMAKE_GLIB(glib-2.0, REQUIRED, 2.44)
On 2019/06/17 07:59:41, knupero wrote:
> A gub build revealed that we use glib 2.38 for freebsd cross builds.
'2.44' must
> be changed to '2.38'

Done.

https://codereview.appspot.com/568820043/diff/582790043/configure.ac#newcode302
configure.ac:302: STEPMAKE_GOBJECT(gobject-2.0, REQUIRED, 2.44)
On 2019/06/17 07:59:41, knupero wrote:
> Same as above, change '2.44' to '2.38'

Done.

https://codereview.appspot.com/568820043/