[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: shepherd a patch?

From: James
Subject: Re: shepherd a patch?
Date: Sat, 16 Nov 2019 10:07:08 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0


On 15/11/2019 13:31, David Nalesnik wrote:
On Fri, Nov 15, 2019 at 4:31 AM James Lowe <address@hidden> wrote:
David et al.

On Fri, 15 Nov 2019 07:33:01 +0100, Urs Liska <address@hidden> wrote:

Hi David,

I feel responsible for this because I know where this is coming from  ;-)

You can send me the patch. However, it's a long time since I uploaded
anything, so I'm not sure my set-up still works. But I'll try.


Am 15.11.19 um 04:10 schrieb David Nalesnik:
Hi all,

I have a patch which implements measure-attached spanners.  I am
having a devil of a time getting the patch up for review.  I simply
can't get git-cl to upload it.  (I suspect this has something to do
with the number of files it touches--my system times out before
everything can be uploaded.)

Would someone be willing to shepherd the patch for me?

Attached is a PNG which shows the output of one of the regtests.

This would _really_ be appreciated.  Thanks!

What I would suggest (generally to anyone on this list that ever needs a patch 
shepherding) is to make sure a tracker exists - @David, as I know you have 
access to create tickets you can at least do this - and then attach your patch 
to that and set the tracker to 'started' so that at the very least if (for 
example) Urs forgets, goes on holiday, has some emergency, that I can at least 
pick it up/detect it on the countdown and put it up for review myself.

I do this all the time for 'drive by' patches.


Thanks for this explanation.  I discovered that my patch had gone to
Rietveld, only no ticket was created.  So the error has to do with the
issue tracker.  Here's hoping that it's possible to do what's left
manually without too much trouble!

Status = 'started'

Patch = 'new'

Those two things will get it on the radar.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]