lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Implement MeasureAttachedSpanner (issue 571180043 by address@hidden)


From: thomasmorley65
Subject: Re: Implement MeasureAttachedSpanner (issue 571180043 by address@hidden)
Date: Sat, 16 Nov 2019 06:42:02 -0800


https://codereview.appspot.com/571180043/diff/565230043/ly/spanners-init.ly
File ly/spanners-init.ly (right):

https://codereview.appspot.com/571180043/diff/565230043/ly/spanners-init.ly#newcode25
ly/spanners-init.ly:25:
"View side-by-side diff with in-line comments" is broken for this file.

https://codereview.appspot.com/571180043/diff/565230043/scm/define-grobs.scm
File scm/define-grobs.scm (right):

https://codereview.appspot.com/571180043/diff/565230043/scm/define-grobs.scm#newcode1457
scm/define-grobs.scm:1457: ;(font-size . -2)
Mmh, this is commented. Why?
Same below.

https://codereview.appspot.com/571180043/diff/565230043/scm/define-music-types.scm
File scm/define-music-types.scm (right):

https://codereview.appspot.com/571180043/diff/565230043/scm/define-music-types.scm#newcode311
scm/define-music-types.scm:311:
"View side-by-side diff with in-line comments" broken here as well

https://codereview.appspot.com/571180043/diff/565230043/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):

https://codereview.appspot.com/571180043/diff/565230043/scm/scheme-engravers.scm#newcode98
scm/scheme-engravers.scm:98: (define-public
(Measure_attached_spanner_engraver context)
Not related to the current patch:
Meanwhile I've seen several scheme-spanners-engravers for new
spanner-grobs (and wrote some for my own work) or to customize existing
spanner-grobs.
All are more or less the same, ofcourse they need to be so.
I'm musing whether it would be possible to create some specialized
macro. We already have `make-engraverĀ“, maybe something like
`make-spanner-engraverĀ“.
Thoughts?

https://codereview.appspot.com/571180043/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]