[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 5639: compile with -std=c++11 (issue 553310045 by address@hidd

From: Dan Eble
Subject: Re: Issue 5639: compile with -std=c++11 (issue 553310045 by address@hidden)
Date: Sun, 15 Dec 2019 09:40:03 -0500

On Dec 15, 2019, at 06:31, address@hidden wrote:
> It is not the commit title, but I do think that this is not a part of issue 
> 5639: compile with --std=c11
> The reason that I think it is important to keep this separated is that the 
> impact is very different.
> When a commit with only comments is in a separate issue, it is easy to cherry 
> pick it for let say version 2.0.
> Although you make it a separate commit, in rietveld it is still one issue.

The effort of handling a separate ticket and review is not worth it to me for 
this particular typo correction.  I'm willing to revert it and leave it for the 
next person who notices it, if that bothers you less than piggybacking on this 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]