[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 5309, take 2: find_global_context () and find_score_context ()
|
From: |
dak |
|
Subject: |
Re: Issue 5309, take 2: find_global_context () and find_score_context () (issue 561290043 by address@hidden) |
|
Date: |
Fri, 03 Jan 2020 13:21:32 -0800 |
https://codereview.appspot.com/561290043/diff/583280043/lily/context.cc
File lily/context.cc (right):
https://codereview.appspot.com/561290043/diff/583280043/lily/context.cc#newcode116
lily/context.cc:116: if (Context *score = gthis->get_score_context ())
On 2020/01/03 16:18:09, lemzwerg wrote:
Not sure whether compilers warn about the `if (... = ...)` construct.
Perhaps
the `Context *` prevents it. Otherwise I suggest another level of
parentheses.
They don't. lily/parser.yy is full of it (and a number of other files
as well) and I have no idea where you want to place "another level of
parentheses". It certainly is not allowed around the declaration.
https://codereview.appspot.com/561290043/