[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Chord names clean-up; no more Banter, exceptionsPartial or \powerCho
Re: Chord names clean-up; no more Banter, exceptionsPartial or \powerChords
Wed, 08 Jan 2020 01:22:40 +0100
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
Flaming Hakama by Elaine <address@hidden> writes:
>> ---------- Forwarded message ----------
>> From: address@hidden
>> To: address@hidden
>> Cc: address@hidden, address@hidden
>> Date: Tue, 07 Jan 2020 14:06:51 -0800
>> Subject: Re: Chord names clean-up; no more Banter, exceptionsPartial or
>> \powerChords. (issue 363880043 by address@hidden)
>> File python/convertrules.py (right):
>> if re.search
>> (r"#[banter|jazz]-chord-names", str):
>> I have no idea what this regexp is actually supposed to be/do. But it
>> needs to get fixed. Any idea what this should be instead?
>> As it is, it matches a # followed by one of the letters abejntrz| and
>> then -chord-names . This is very likely not what is intended here.
> My guess as to the intention is that it should match either
> "#banter-chord-names" or "#jazz-chord-names".
> Although, it is unclear why those strings are important.
> Seems like they just mistakenly used square brackets instead of parenthesis
> for grouping in the regular expression.
Ah yes, that makes sense. Of course, those patterns are garbage as well
since the correct names would be banter-chordnames and jazz-chordnames.
But at least it appears like we are getting somewhere.