[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
ly_scm_write_string: call scm_write directly (issue 545450043 by address
|
From: |
dak |
|
Subject: |
ly_scm_write_string: call scm_write directly (issue 545450043 by address@hidden) |
|
Date: |
Sat, 18 Jan 2020 15:29:30 -0800 |
LGTM
https://codereview.appspot.com/545450043/diff/583370043/lily/lily-guile.cc
File lily/lily-guile.cc (right):
https://codereview.appspot.com/545450043/diff/583370043/lily/lily-guile.cc#newcode55
lily/lily-guile.cc:55: scm_write(s, port);
Well, I was "what the Dickens?" reading this. I suppose the original
purpose of the code is to follow redefinitions of "write". I cannot
imagine that to be overly useful, though.
https://codereview.appspot.com/545450043/
- ly_scm_write_string: call scm_write directly (issue 545450043 by address@hidden),
dak <=