[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: github mirror of lilypond?

From: David Kastrup
Subject: Re: github mirror of lilypond?
Date: Mon, 20 Jan 2020 16:47:13 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Werner LEMBERG <address@hidden> writes:

>>> Han-Wen has recently pushed a bunch of changes directly to
>>> Rietveld, most of them quite uncontroversial.  I assume that this
>>> is as good as an e-mail :-)
>>> I thus suggest that after his patches have been reviewed,
>> How are they going to get reviewed when there is nothing pointing to
>> them?  How would anyone including Han-Wen know when the review phase
>> ends?
> Well, as has been pointed out, pull requests at github don't have
> 'review phases', and what we have here is comparable IMHO.
> One developer (or maybe two, just to be sure) acknowledges the patch,
> and that's it.  Kind of a highway solution for trivial things.

Trivial things from a developer with push access can be just pushed.
Complex or otherwise contential things warrant a chance for developers
to take a look at it.  "Half a chance" seems an unnecessary

David Kastrup

reply via email to

[Prev in Thread] Current Thread [Next in Thread]