Re: Explain dead code for GUILE2 (issue 547470043 by address@hidden)

[hanwenn]

Reviewers: lemzwerg, Dan Eble,


https://codereview.appspot.com/547470043/diff/547480043/lily/main.cc
File lily/main.cc (right):

https://codereview.appspot.com/547470043/diff/547480043/lily/main.cc#newcode447
lily/main.cc:447: /* this code is dead, but keeping this around until we
sort the
On 2020/01/24 18:05:08, Dan Eble wrote:
> LGTM, but ...
> 
> "'Mostly dead' is 'slightly alive.'"
> 
> It sounds like you think you might need to reinstate this.  Consider
keeping the
> #if GUILE2 and wrapping the code in if (false) {...}.  That way it
will have to
> remain compilable in the meantime, so it will be closer to ready when
you need
> it.
> 
> Also, the title of this review is "Explain dead code for GUILE2," but
the change
> appears to go beyond explanation into modification.

note that the #define is GUILEV2 so this was always equivalent to #if 0

Description:
Explain dead code for GUILE2

Please review this at https://codereview.appspot.com/547470043/

Affected files (+3, -1 lines):
  M lily/main.cc


Index: lily/main.cc
diff --git a/lily/main.cc b/lily/main.cc
index 
60b5738265e6d9a41f9ad2dcfecf887c823de01c..37efa7168094b62403b804361b47c2d433601cf6
 100644
--- a/lily/main.cc
+++ b/lily/main.cc
@@ -443,7 +443,9 @@ main_with_guile (void *, int, char **)
    prepend_scheme_list (lilypond_datadir, scm_pct_load_path );
    prepend_scheme_list (lilypond_datadir + "/scm", scm_pct_load_path);
 
-#if (GUILE2)
+#if 0
+   /* this code is dead, but keeping this around until we sort the
+      guile2/3 situation. */
    /*
      Just as ughy - prepend "/scm/out" onto GUILE V2+ %load-compiled-path
      and set %compile-fallback-path to our scm/out directory