[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Remove dead code throughout (issue 547470044 by address@hidden)
|
From: |
hanwenn |
|
Subject: |
Re: Remove dead code throughout (issue 547470044 by address@hidden) |
|
Date: |
Fri, 24 Jan 2020 10:50:22 -0800 |
https://codereview.appspot.com/547470044/diff/575540047/lily/include/smobs.hh
File lily/include/smobs.hh (left):
https://codereview.appspot.com/547470044/diff/575540047/lily/include/smobs.hh#oldcode316
lily/include/smobs.hh:316: SCM protection_cons_;
On 2020/01/24 18:21:40, Dan Eble wrote:
> Changing the size of a structure is not the first thing that comes to
mind when
> someone says "dead-code removal." I'm happy to see this change, but
it could be
> summarized a little better.
Done.
https://codereview.appspot.com/547470044/diff/575540047/lily/include/smobs.hh
File lily/include/smobs.hh (right):
https://codereview.appspot.com/547470044/diff/575540047/lily/include/smobs.hh#newcode319
lily/include/smobs.hh:319: Smob () { };
On 2020/01/24 18:21:40, Dan Eble wrote:
> Try this:
>
> Smob () = default;
Done.
https://codereview.appspot.com/547470044/