Re: Provide --loglevel=PROGRESS for make VERBOSE=1 (issue 575540044 by address@hidden)

[hanwenn]

Reviewers: Dan Eble,

Message:
On 2020/01/27 02:52:44, Dan Eble wrote:
> > This provides enough information to diagnose problems in included
> > files while building the documentation.
> 
> LGTM, though I wonder why these problems (whatever they are) do not
trigger
> useful diagnostic messages at WARN or higher levels, which would be
seen even at
> the default verbosity level.  In other words, is this change just
working around
> deficiencies of the program?

kind of. If there is a problem with an input file, the progress messages
would tell you what
the last file processed was. 

The clean way to do this, is to catch the exception in python, annotate
it with the current file
and rethrow. It's more work, and this gets it done well enough for
debugging.

Description:
Provide --loglevel=PROGRESS for make VERBOSE=1

This provides enough information to diagnose problems in included
files while building the documentation.

Please review this at https://codereview.appspot.com/575540044/

Affected files (+4, -0 lines):
  M make/lilypond-vars.make


Index: make/lilypond-vars.make
diff --git a/make/lilypond-vars.make b/make/lilypond-vars.make
index 
2274e173ba548c2079a160439c649fae455909d0..66b64b52496f9be96925586dad29fb6fafbeffe0
 100644
--- a/make/lilypond-vars.make
+++ b/make/lilypond-vars.make
@@ -56,7 +56,11 @@ endif
 ifdef SILENT
   LILYPOND_BOOK_WARN = --loglevel=WARN
 else
+ ifdef VERBOSE
+  LILYPOND_BOOK_WARN = --loglevel=PROGRESS
+ else
   LILYPOND_BOOK_WARN = --loglevel=BASIC
+ endif
 endif
 
 LILYPOND_BOOK_INFO_IMAGES_DIR = $(if 
$(INFO_IMAGES_DIR),--info-images-dir=$(INFO_IMAGES_DIR),)