Re: GUILE2: generate internals doc in UTF-8 (issue 575540045 by address@hidden)

[dak]

On 2020/01/27 08:23:41, hanwenn wrote:
> On 2020/01/24 11:15:10, hanwenn wrote:
> >
>
https://codereview.appspot.com/575540045/diff/571410043/scm/documentation-generate.scm
> > File scm/documentation-generate.scm (right):
> > 
> >
>
https://codereview.appspot.com/575540045/diff/571410043/scm/documentation-generate.scm#newcode98
> > scm/documentation-generate.scm:98: (if (defined?
'set-port-encoding!)
> > On 2020/01/24 11:08:51, dak wrote:
> > > I think we usually do this as
> > > 
> > > (if (guile-v2) ...
> > > 
> > > in order to better be able to find dependencies and ultimately
(after
> > migration)
> > > throw them out.  Also I am not sure that the byte-compiler is
happy about
> > those
> > > constructs.
> > 
> > Done.
> 
> ping.

I now set status of issue #5683 back to Patch-new to trigger retesting. 
If you submit followup patches via git-cl, that should happen
automatically.

https://codereview.appspot.com/575540045/