[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 5698: int->vsize in various alignment and page-layout methods
From: |
nine . fierce . ballads |
Subject: |
Re: Issue 5698: int->vsize in various alignment and page-layout methods (issue 563420043 by address@hidden) |
Date: |
Mon, 27 Jan 2020 04:40:38 -0800 |
Reviewers: lemzwerg, hanwenn, dan_faithful.be,
https://codereview.appspot.com/563420043/diff/547500043/lily/grob.cc
File lily/grob.cc (right):
https://codereview.appspot.com/563420043/diff/547500043/lily/grob.cc#newcode492
lily/grob.cc:492: return real_ext;
On 2020/01/27 06:33:09, lemzwerg wrote:
> whitespace
Thank you. Done in my local copy.
https://codereview.appspot.com/563420043/diff/547500043/lily/include/align-interface.hh
File lily/include/align-interface.hh (right):
https://codereview.appspot.com/563420043/diff/547500043/lily/include/align-interface.hh#newcode37
lily/include/align-interface.hh:37: get_pure_minimum_translations (Grob
*, std::vector<Grob *> const &,
On 2020/01/27 06:33:09, lemzwerg wrote:
> maybe indent this line by two spaces?
That would be inconsistent with the style in other headers (e.g.
smobs.hh, translator.hh). If this is a readability issue, would adding
a blank line above and below this declaration help?
Description:
https://sourceforge.net/p/testlilyissues/issues/5698/
fixes warnings
Please review this at https://codereview.appspot.com/563420043/
Affected files (+64, -47 lines):
M lily/align-interface.cc
M lily/axis-group-interface.cc
M lily/grob.cc
M lily/grob-property.cc
M lily/include/align-interface.hh
M lily/include/axis-group-interface.hh
M lily/include/grob.hh
M lily/include/item.hh
M lily/include/page-layout-problem.hh
M lily/item.cc
M lily/page-layout-problem.cc
Re: Issue 5698: int->vsize in various alignment and page-layout methods (issue 563420043 by address@hidden),
nine . fierce . ballads <=
Re: Issue 5698: int->vsize in various alignment and page-layout methods (issue 563420043 by address@hidden), jonas . hahnfeld, 2020/01/27
Re: Issue 5698: int->vsize in various alignment and page-layout methods (issue 563420043 by address@hidden), nine . fierce . ballads, 2020/01/27