Re: 2.91.84 - windows-only bugs

[Thomas Morley]

Am Mi., 29. Jan. 2020 um 13:21 Uhr schrieb David Kastrup <address@hidden>:
>
> Thomas Morley <address@hidden> writes:
>
> > Hi all,
> >
> > iirc in Salzburg there was the plan to do a 2.19.84-release, soon
> > followed by stable 2.20
> > May I ask how's the state of 2.19.84?
>
> I just got news from Phil (who had been offline for a while) and he
> plans to set to it this weekend, time allowing.
>
> > I ask because, in the german forum Arnold found a method to cure some
> > windows-only bugs., about mis-predicted force and probably several
> > assertion-failures:
> > https://lilypondforum.de/index.php/topic,609.msg3463.html#msg3463
> >
> > Though,  this would first need to be reviewed and put in the source
> > and then been tested by users.
> > For the latter, I made a windows-installer containing this patch and
> > could post about it on -user for testing.
> >
> > Alternatively, we could postpone it, implementing it in 2.21
> >
> > Thoughts?
>
> After 2.19.84, we stipulated a two-week window until 2.20.  I'd propose
> that you try getting the respective patch into review right now if it is
> ok for you, and we aim for its appearance in 2.19.84 (by being as rushed
> about including it and cherry-picking into the stable branch as
> appropriate, and, if push comes to shove, giving a slight delay to
> 2.19.84).  This is kind of an important thing to have fixed in the
> stable release if we see a chance of doing so, and having that two-week
> window would be a good thing.

Patch is up,
https://codereview.appspot.com/577450043
added to
https://sourceforge.net/p/testlilyissues/issues/4943/

> I haven't yet looked at the patch/discussion yet: this is just my first
> reaction rather than an LGTM.

Understood

Thanks,
  Harm