[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: lilypond-book: Rewrite processing of snippets (issue 555220043 by ad
From: |
jonas . hahnfeld |
Subject: |
Re: lilypond-book: Rewrite processing of snippets (issue 555220043 by address@hidden) |
Date: |
Sun, 02 Feb 2020 05:26:03 -0800 |
On 2020/02/02 13:21:58, Dan Eble wrote:
> On 2020/02/02 09:52:37, hahnjo wrote:
> >
>
https://codereview.appspot.com/555220043/diff/553480046/scripts/lilypond-book.py#newcode432
> > scripts/lilypond-book.py:432: snippet_names_file =
'snippet-names-%s.ly' %
> > checksum
> > On 2020/02/01 16:54:40, Dan Eble wrote:
> > > It's strange that this is named *.ly but does not contain ly code.
That's
> not
> > > your problem, though.
> >
> > True. It's now relatively simple to change, what would you prefer?
>
> I'd probably have chosen txt.
Ok, will do.
> New topic: Do you recommend any manual steps to clean up the workspace
before
> running tests with these changes, or should it work seamlessly?
It should complete without issues, but you'll again see many profiling
differences because of the changed order. After this change has landed,
you should recreate a test-baseline.
https://codereview.appspot.com/555220043/
- lilypond-book: Rewrite processing of snippets (issue 555220043 by address@hidden), nine . fierce . ballads, 2020/02/01
- Re: lilypond-book: Rewrite processing of snippets (issue 555220043 by address@hidden), hanwenn, 2020/02/01
- Re: lilypond-book: Rewrite processing of snippets (issue 555220043 by address@hidden), jonas . hahnfeld, 2020/02/02
- Re: lilypond-book: Rewrite processing of snippets (issue 555220043 by address@hidden), nine . fierce . ballads, 2020/02/02
- Re: lilypond-book: Rewrite processing of snippets (issue 555220043 by address@hidden),
jonas . hahnfeld <=
- Re: lilypond-book: Rewrite processing of snippets (issue 555220043 by address@hidden), jonas . hahnfeld, 2020/02/02
- Re: lilypond-book: Rewrite processing of snippets (issue 555220043 by address@hidden), nine . fierce . ballads, 2020/02/02