[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: engraver: continue when trying to create non-existent Grob (issue 54
From: |
dak |
Subject: |
Re: engraver: continue when trying to create non-existent Grob (issue 547620043 by address@hidden) |
Date: |
Mon, 10 Feb 2020 13:40:03 -0800 |
On 2020/02/10 21:35:30, hanwenn wrote:
> On 2020/02/10 21:31:46, dak wrote:
> >
https://codereview.appspot.com/547620043/diff/545560043/lily/engraver.cc
> > File lily/engraver.cc (right):
> >
> >
>
https://codereview.appspot.com/547620043/diff/545560043/lily/engraver.cc#newcode126
> > lily/engraver.cc:126: grob = new Item (SCM_EOL);
> > Ugh. How is that going to work? I am not sure we aren't better off
with a
> hard
> > exit. Admittedly, a failed assertion makes little sense after a
> > programming_error: this should have been a hard error in the first
place.
> >
> > What is the use case?
>
> Without this, you get a segfault because we take a cdr of an empty
list.
Ugh. Ok, that's rather awful. But don't we run into followup errors
with that make_item (SCM_EOL) ?
https://codereview.appspot.com/547620043/