lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Don't count terminating \0 in Source_file::length (issue 579310043 b


From: hanwenn
Subject: Re: Don't count terminating \0 in Source_file::length (issue 579310043 by address@hidden)
Date: Sat, 15 Feb 2020 09:07:21 -0800

https://codereview.appspot.com/579310043/diff/557420043/lily/source-file.cc
File lily/source-file.cc (right):

https://codereview.appspot.com/579310043/diff/557420043/lily/source-file.cc#newcode55
lily/source-file.cc:55: return contents of FILENAME. *Not 0-terminated!*
On 2020/02/15 13:53:17, Dan Eble wrote:
> update

Done.

https://codereview.appspot.com/579310043/diff/557420043/lily/source-file.cc#newcode84
lily/source-file.cc:84: string dest;
On 2020/02/15 13:53:17, Dan Eble wrote:
> I'd construct with (count, character) rather than construct empty and
resize.

Done.

https://codereview.appspot.com/579310043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]