[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 5788: New French Beamimg Approach (issue 557500043 by address@
From: |
lemzwerg |
Subject: |
Re: Issue 5788: New French Beamimg Approach (issue 557500043 by address@hidden) |
Date: |
Sun, 23 Feb 2020 21:24:25 -0800 |
LGTM. Very nice, thanks! Some minor nits only.
https://codereview.appspot.com/557500043/diff/551490044/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/557500043/diff/551490044/Documentation/changes.tely#newcode67
Documentation/changes.tely:67: @emph{exactly} behaves like standard
(i.e. default) beaming in every respect
s/i.e./i.e.,/
https://codereview.appspot.com/557500043/diff/551490044/Documentation/changes.tely#newcode68
Documentation/changes.tely:68: (beam positioning and placement of any
articulation/fingering/etc.). The
... articulation, fingering, etc.
https://codereview.appspot.com/557500043/diff/551490044/Documentation/changes.tely#newcode69
Documentation/changes.tely:69: only remaining difference being inner
stems not passing through beams.
s/being/are/
https://codereview.appspot.com/557500043/diff/551490044/input/regression/beam-french.ly
File input/regression/beam-french.ly (right):
https://codereview.appspot.com/557500043/diff/551490044/input/regression/beam-french.ly#newcode23
input/regression/beam-french.ly:23: { d32[^1 e^2 f^3 g^4 a^5] } s64
Please add one or more test cases for your 'french-correction' property.
https://codereview.appspot.com/557500043/
- Issue 5788: New French Beamimg Approach (issue 557500043 by address@hidden), torsten . haemmerle, 2020/02/23
- Re: Issue 5788: New French Beamimg Approach (issue 557500043 by address@hidden),
lemzwerg <=
- Re: Issue 5788: New French Beamimg Approach (issue 557500043 by address@hidden), hanwenn, 2020/02/24
- Re: Issue 5788: New French Beamimg Approach (issue 557500043 by address@hidden), torsten . haemmerle, 2020/02/25
- Re: Issue 5788: New French Beamimg Approach (issue 557500043 by address@hidden), torsten . haemmerle, 2020/02/25
- Re: Issue 5788: New French Beamimg Approach (issue 557500043 by address@hidden), lemzwerg, 2020/02/25
- Re: Issue 5788: New French Beamimg Approach (issue 557500043 by address@hidden), torsten . haemmerle, 2020/02/25
- Re: Issue 5788: New French Beamimg Approach (issue 557500043 by address@hidden), dak, 2020/02/25
- Re: Issue 5788: New French Beamimg Approach (issue 557500043 by address@hidden), dak, 2020/02/25
- Re: Issue 5788: New French Beamimg Approach (issue 557500043 by address@hidden), lemzwerg, 2020/02/25
- Re: Issue 5788: New French Beamimg Approach (issue 557500043 by address@hidden), torsten . haemmerle, 2020/02/26
- Re: Issue 5788: New French Beamimg Approach (issue 557500043 by address@hidden), hanwenn, 2020/02/26