Re: Issue 5788: New French Beamimg Approach (issue 557500043 by address@hidden)

[torsten . haemmerle]

On 2020/02/26 21:04:59, Be-3 wrote:
> Changes applied following the reviewers' comments

All of the recommendations applied:

    Rename stru Beam_stem_length ->  Beam_stem_end (Han-Wen)
    Rename property french-correction -> stem-end-shorten (Han-Wen)
    
    Make property stem-end-shorten (was: french-correction) internal
(DAK)
    
    Corrections to doc text (Werner)
    
    New regression file added directly comparing french beaming to
standard
    beaming (Werner)
    
    On my behalf:
    Modified changes.tely LilyPond example to show more variations in
less
    space so that it will not stick out into the margin in PDF version.

    Removed an unneccessary if, just multiplying by int 0 in this case.
    
    Full test successfully performed.


@DAK: Sorry, the french-correction property (now: stem-end-shorten) was
supposed
to be internal (as you guessed correctly in the end).  But I had
initially put it
in the all-user-grob-properties list in an early testing stage and plain
and
simply forgot to move it over to all-internal-grob-properties in time.

Cheers and thanks for reviewing,
Torsten




https://codereview.appspot.com/557500043/