[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Added transition lines for lyrics (issue 565750043 by address@hidden

From: hanwenn
Subject: Re: Added transition lines for lyrics (issue 565750043 by address@hidden)
Date: Sun, 15 Mar 2020 08:00:49 -0700
File Documentation/notation/vocal.itely (right):
Documentation/notation/vocal.itely:894: ah \vowelTransition _ _ _ _
is it vowel transtition or lyric transition?

make the grob name consistent (grob VowelTransition, or identifier
File lily/ (right):
lily/ w += -d * r->item_drul_[d]->extent
(r->item_drul_[d], X_AXIS)[-d];
this looks suspect. If you translate either items (relative to the
paper-column it is attached to), then this will leave the rod alone.
Shouldn't the extent be relative to the item' paper column?
lily/ SCM min_length_correction = me->get_property
the behavior you add is specific to your new feature, so I think it
would be best to avoid changing (and at the same time,
avoiding wholesale copies of this code)

Could you summarize for me what the behavior should be? Sorry for being
a little dense here.  (And how should they behave across line breaks?)

It is strange to introduce a minimum-length-correction, when you could
introduce a callback for minimum-length that calculates a different
lily/ r.distance_ -= bounds_protrusion (&r);
this is weird.  You're using r.item_drul_ here, but then in the next
line, you overwrite r.item_drul_. What's going on?
lily/ r.distance_ += bounds_protrusion (&r);
and now you're doing += after doing -=  ?
File scm/define-grobs.scm (right):
scm/define-grobs.scm:1471: (minimum-length-correction .
The function calc-xxx is usually used for calculating the xxx property,
so the naming is off.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]