lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Define Scheme markups using define-public (issue 577720043 by addres


From: hanwenn
Subject: Re: Define Scheme markups using define-public (issue 577720043 by address@hidden)
Date: Mon, 30 Mar 2020 14:18:17 -0700

On 2020/03/30 12:20:17, dak wrote:
> On 2020/03/29 14:35:43, hanwenn wrote:
> > On Sun, Mar 29, 2020 at 4:12 PM <mailto:address@hidden> wrote:
> > >
> > > On 2020/03/29 13:55:41, hanwenn wrote:
> > > > On 2020/03/29 13:52:48, hanwenn wrote:
> > > > > retain existing
> > > >
> > > > how's this? This leaves things backward compatible.
> > >
> > > Ugly and a maintenance burden since the code is used twice. 
Anything
> > > wrong with my proposal?
> > 
> > I didn't understand your proposal.
> > 
> > > It does not have duplicate code, makes
> > > define-markup-command compilable (while requiring its toplevel
use) and
> > > provides a way of doing the same consistently for module-specific
rather
> > > than toplevel use.
> > >
> > > It sacrifices, like your proposal, non-toplevel-performance for
the sake
> > > of compilability in Guilev2.  It's just that what the parser then
uses
> > > is in a form that could also be used in a reasonably natural
manner from
> > > Scheme.
> > >
> > > Should I write up a patch doing that?
> > 
> > Yes please.
> > 
> 
> Working on it.  By the way, it just occured to me that a whole lot of
trouble
> with byte-compilation is caused by the markup macro.

Yes, it was the next thing I wanted to look at, but you beat me to the
punch.


https://codereview.appspot.com/577720043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]