Re: Refactor \markup \pattern (issue 549780045 by address@hidden)

[hanwenn]

https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):

https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-commands.scm#newcode4675
scm/define-markup-commands.scm:4675: (count (inexact->exact (truncate (/
(- middle-width pattern-width) period))))
On 2020/03/31 22:17:02, dak wrote:
> On 2020/03/31 20:22:35, hanwenn wrote:
> > unrelated change?
> 
> Prerequisite.  The previous version of \pattern was coded in a manner
where it
> accepted unexact integers which does not make sense.  But our
predicates don't
> catch that even where warranted and a lot of code will bomb out on
inexact
> integers late.  Fixing the specific problem here for now made most
sense and
> would have been required anyway if the predicates had been made more
stringent. 
> And since it should have been like this in the first place for obvious
reasons,
> adding a comment here did not make a lot of sense, either.

got it. maybe add as a comment to commit message.

https://codereview.appspot.com/549780045/