Re: Abstract Grob property storage into Mutable_properties. (issue 561640043 by address@hidden)

[hanwenn]

Reviewers: lemzwerg,

Message:
On 2020/04/13 14:58:01, lemzwerg wrote:
> From visual inspection, LGTM.
> 
> I only wonder whether we should use
> 
>   if
>   {
>     foo(...);
>   }
> 
> or
> 
>   if
>     foo(...);
> 
> for single statements ­– right now, the source code contains both
variants...

I have been drilled at google to always use the { }, so that's why.
Before, we used the braceless version when it was possible. Standards
are wonderful; there are so many to choose from.

Description:
Abstract Grob property storage into Mutable_properties.

No functional changes. This change makes it easier to understand the
follow-on change, which reorganizes the storage for mutable
properties with significant performance improvements.

Please review this at https://codereview.appspot.com/561640043/

Affected files (+235, -88 lines):
  M lily/break-substitution.cc
  M lily/grob.cc
  M lily/grob-property.cc
  M lily/grob-scheme.cc
  M lily/grob-smob.cc
  M lily/include/grob.hh
  A lily/include/mutable-properties.hh
  A lily/mutable-properties.cc