lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Make GET_LISTENER take a pointer arg and deduce its type (issue 5498


From: dak
Subject: Re: Make GET_LISTENER take a pointer arg and deduce its type (issue 549890043 by address@hidden)
Date: Sat, 18 Apr 2020 10:53:34 -0700

On 2020/04/18 14:43:24, Dan Eble wrote:
> On 2020/04/18 14:31:33, dak wrote:
> > If we consider type_traits as a sunk cost, I'll see whether I can
find
> anything
> > in it to address the inheritance wart you complained of.
> 
> As you already put in some time there, I wouldn't think less of you if
you just
> left the static_cast in Global_context and moved on.

Well, after a refactoring (patch set 5) it was just a few lines (patch
set 6) but unfortunately this time definitely requiring some hand-spun
type trait punning.  Not particularly great.

https://codereview.appspot.com/549890043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]