lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patchy email


From: Thomas Morley
Subject: Re: Patchy email
Date: Sun, 19 Apr 2020 22:32:38 +0200

Am So., 19. Apr. 2020 um 21:59 Uhr schrieb Jonas Hahnfeld <address@hidden>:
>
> Am Sonntag, den 19.04.2020, 18:20 +0000 schrieb Valentin Villenave:
> > On 4/19/20, David Kastrup <
> > address@hidden
> > > wrote:
> > > mkstemp! does not generate a string.  It overwrites an existing string
> > > in-place, and that's bad news for a literal string.
> >
> > Yes, it overwrite the string, opens a port, then I read the
> > port-filename which should be an _other_ string object, shouldn’t it?
> > (sigh -- _none_ of this would happen if they hadn’t decided to remove
> > tmpnam, or if they had bothered to make tmpnam behave correctly and
> > respect TMPDIR, or if they had a mkdtemp! function.)
>
> Hm, where's that deprecation notice? The web page [1] only says you
> have to be careful in case of a malicious attacker. But we're talking
> about a test here, so I don't think this applies.
>
> 1: 
> https://www.gnu.org/software/guile/manual/html_node/File-System.html#index-tmpnam

It's deprecated in Guile 3.0.2
https://lists.gnu.org/archive/html/guile-devel/2020-03/msg00046.html
Thus, I voted against introducing it during patchreview:
https://codereview.appspot.com/557640051/#msg4

Cheers,

  Harm



reply via email to

[Prev in Thread] Current Thread [Next in Thread]