Re: poll: switching our development platform

[Carl Sorensen]

Sending it only to you was not intended.  I must have hit reply instead of 
reply-all, and I didn't notice it.  I'm sorry!

I guess I'm being lazy right now.  I don't have a good lilypond development 
environment set up right now, so I don't have any merge requests to send.  I 
guess I could just clone the git repository  and pick a random commit to put up 
as a merge request.  But if I put it up, I don't get to see how I would respond 
as a reviewer; my experience would be as a merge requester.  That's why I was 
asking for a merge request that touched multiple files.

As far as the countdown process goes, I thought that your patch labels exactly 
matched our current process.   It seems like we could add a milestone for the 
push date once we move to countdown status, and we'd be following our process 
exactly but also have a publicly-viewable indication of the status on the issue 
tracker.

Thanks,

Carl




On 4/23/20, 10:27 AM, "Jonas Hahnfeld" <address@hidden> wrote:

Hi Carl,

I just noticed that this message did not go to the mailing list; not
sure if that was intended?

Regarding testing: In my opinion the critical point is our countdown
process. I guess any review tool is of some use, but we have very
specific needs with respect to labels and such.
With respect to merge requests, everybody can open some to get a
feeling of the platform. After all I've already been using GitLab for
some time and know how it works 😉

Cheers
Jonas

Am Mittwoch, den 22.04.2020, 15:13 +0000 schrieb Carl Sorensen:
> I've tested out GitLab for reviewing Jonas's patch.  For this patch, the 
> review process seems nice.  There is a video that demonstrates code review on 
> GitLab:  
> https://drive.google.com/file/d/0BwXthOgZCRQQWXVIM3dwZThXd2M/view
> 
> 
> For a patch that affects only a single file, the GitLab review tools seem 
> good to me.
> 
> I haven't had the chance to explore reviewing a change that touches multiple 
> files.
> 
> @Jonas, could you put a merge request up that touches multiple files so that 
> we can experiment with the code review process?
> 
> So far, I like things quite well.  I like the look of the issues list.  I 
> like that we have images.  I like that GitLab is open source code so we won't 
> be in the lurch if GitLab.com suddenly shuts down.  I like having only a 
> single platform with which to contend, instead of 2 (or 3).  I like the 
> potential for CI tools.  It would be great if James's job to run patchy and 
> send emails to the list could go away (not that I want James to go away, but 
> it would be nice if he didn't have to do jobs that could be automated).
> 
> Thanks for doing this, Jonas!  I think it's really promising.
> 
> Carl