lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Fix warnings related to po (issue 551830043 by address@hidden)


From: lemzwerg
Subject: Fix warnings related to po (issue 551830043 by address@hidden)
Date: Fri, 24 Apr 2020 11:25:33 -0700

LGTM, thanks a lot!


https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile
File po/GNUmakefile (right):

https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile#newcode14
po/GNUmakefile:14: sed-makestuff = -e 's/[a-zA-Z_/]*make\[[0-9]*\].*//'
shouldn't this be rather '[0-9]\+'?

https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile#newcode15
po/GNUmakefile:15: sed-edstuff = -e 's/[ \.,adic0-9]*//' -e 's/---//' |
sort -u
I think that within '[...]' you don't have to escape '.'.

And again I would use '\+' instead of '*'.

https://codereview.appspot.com/551830043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]