[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Minor cleanups in stencil-integral.cc (issue 579630043 by address@hi
From: |
Carl . D . Sorensen |
Subject: |
Re: Minor cleanups in stencil-integral.cc (issue 579630043 by address@hidden) |
Date: |
Fri, 24 Apr 2020 14:33:12 -0700 |
On 2020/04/24 21:19:57, dak wrote:
> On 2020/04/24 21:18:12, dak wrote:
> >
>
https://codereview.appspot.com/579630043/diff/555740043/lily/stencil-integral.cc
> > File lily/stencil-integral.cc (right):
> >
> >
>
https://codereview.appspot.com/579630043/diff/555740043/lily/stencil-integral.cc#newcode465
> > lily/stencil-integral.cc:465: // more convoluted, but it's fairly
hot path.
> > Sorry for not being clear: the question was not why this change was
effective
> in
> > saving time, but why it was valid. When thickness is zero, you only
update
> the
> > upper skyline. Why would the lower skyline no longer need updating?
>
> Well, other way round, but apart from that the question stands.
When thickness is zero, the upper and lower curves are the same. Either
one completes the skyline.
https://codereview.appspot.com/579630043/
- Re: Minor cleanups in stencil-integral.cc (issue 579630043 by address@hidden), dak, 2020/04/24
- Re: Minor cleanups in stencil-integral.cc (issue 579630043 by address@hidden), dak, 2020/04/24
- Re: Minor cleanups in stencil-integral.cc (issue 579630043 by address@hidden),
Carl . D . Sorensen <=
- Re: Minor cleanups in stencil-integral.cc (issue 579630043 by address@hidden), dak, 2020/04/24
- Re: Minor cleanups in stencil-integral.cc (issue 579630043 by address@hidden), hanwenn, 2020/04/25
- Re: Minor cleanups in stencil-integral.cc (issue 579630043 by address@hidden), dak, 2020/04/25
- Re: Minor cleanups in stencil-integral.cc (issue 579630043 by address@hidden), hanwenn, 2020/04/25