lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Use Scheme_hash_table for keyword handling (issue 577840053 by addre


From: nine . fierce . ballads
Subject: Re: Use Scheme_hash_table for keyword handling (issue 577840053 by address@hidden)
Date: Mon, 27 Apr 2020 15:31:32 -0700

On 2020/04/27 22:07:07, dak wrote:
>
https://codereview.appspot.com/577840053/diff/561760044/lily/lily-lexer.cc
> File lily/lily-lexer.cc (right):
> 
>
https://codereview.appspot.com/577840053/diff/561760044/lily/lily-lexer.cc#newcode97
> lily/lily-lexer.cc:97: Protected_scm Lily_lexer::keytable_;
> On 2020/04/27 21:22:59, hanwenn wrote:
> > could move out of Lily_lexer.
> 
> It's only used in there and changing it elsewhere would be really bad,
so why?

I was about to say this.  And as it stands, it is obviously initialized
before it is used.  As a global, who knows?  I wouldn't spend any time
trying to find another way.

https://codereview.appspot.com/577840053/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]