[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Proposed cleanup for 'annotation and 'font-size for slur/tie-like gr
From: |
Thomas Morley |
Subject: |
Re: Proposed cleanup for 'annotation and 'font-size for slur/tie-like grobs |
Date: |
Mon, 20 Jul 2020 20:08:37 +0200 |
Am Mo., 20. Juli 2020 um 12:04 Uhr schrieb Thomas Morley
<thomasmorley65@gmail.com>:
>
> Hi,
>
> I noticed that Tie, Slur, PhrasingSlur, RepeatTie and LaissezVibrerTie
> can be annotated by
> \override <curve> . annotation = "some-text"
>
> {
> \override Slur.font-size = 0
> \override Tie.font-size = 0
> \override PhrasingSlur.font-size = 0
> \override RepeatTie.font-size = 0
> \override LaissezVibrerTie.font-size = 0
>
> \override Slur.annotation = "Slur"
> \override Tie.annotation = "Tie"
> \override PhrasingSlur.annotation = "PhrasingSlur"
> \override RepeatTie.annotation = "RepeatTie"
> \override LaissezVibrerTie.annotation = "LaissezVibrerTie"
>
> b1( c')
> b1\( c'\)
> b~b
> <b f'>~ <b f'>
> b\repeatTie
> b\laissezVibrer
> }
>
> Alas, the implementation is not consistent.
> Tie is the only one having font-size set per default, Slur uses a
> fallback value in slur.cc, the other miss `annoatation` and
> `font-size`.
> This leads to several programming errors if compiled with
> -dcheck-internal-types:
> programming error: Grob `Slur' has no interface for property `font-size'
>
> Especially Tie.font-size is getting on my nerves if I code
> custom-stencils for all sorts of curves.
>
> I propose a clean up:
> Add `annotation` and `font-size` to tie.cc, semi-tie.cc and slur.cc
> (where missing)
> Delete Tie.font-size in define-grobs.scm
> Use the same fallback for Tie.font-size in tie.cc as it's done in slur.cc
>
> Not sure why annotations for tie-like curves are placed and colored
> differently, though, I don't intend to change this.
>
> Would a patch along these lines be acceptable?
>
>
> Thanks,
> Harm
No objection so far, thus:
https://gitlab.com/lilypond/lilypond/-/merge_requests/264
Cheers,
Harm