[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Could not find ottavation markup

From: Michael Käppler
Subject: Re: Could not find ottavation markup
Date: Wed, 30 Sep 2020 21:56:05 +0200
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0

Am 29.09.2020 um 14:38 schrieb Dan Eble:
Using the latest version of master, I'm seeing the warning "Could not find 
ottavation markup for 1 octaves up" in a number of my scores when MIDI output is 
enabled.  This warning was added about a year ago in commit 
476194c706e4f9898fdbd5847dc1a924843f03e8 for Issue 5559.

How should this be addressed?  I can think of a few alternatives.

* define the markup in performer init (seems wrong)
* remove the warning
* before issuing the warning, check another property
   like in ab4f3cd2ad792b848c1045fd572b5f119a180d23

I lean toward removing the warning.
Hi Dan,
what about this: (only tested with your MWE, though)

diff --git a/scm/define-music-callbacks.scm b/scm/define-music-callbacks.scm
index 2d1bb97657..01d1c89854 100644
--- a/scm/define-music-callbacks.scm
+++ b/scm/define-music-callbacks.scm
@@ -83,6 +83,7 @@ to be used by the sequential-iterator"
                 (set! (ly:context-property context 'middleCOffset) offset)
                 (set! (ly:context-property context 'ottavation)
                 (if (and (not (zero? octavation))
+                         (not (null? markups))
                          (not (markup? ottavation-markup)))
                     (ly:warning "Could not find ottavation markup for
~a octaves up." octavation))
                 (ly:set-middle-C! context))))


reply via email to

[Prev in Thread] Current Thread [Next in Thread]