Re: PATCHES - Countdown for February 5th

[Jean Abou Samra]

Le 03/02/2022 à 21:43, Colin Campbell a écrit :
> On 2022-02-03 13:04, Jean Abou Samra wrote:
> > Le 03/02/2022 à 20:18, Colin Campbell a écrit :
> > > !1019 RFC: Add syntax highlighting to documentation - Jean Abou Samra
> > > https://gitlab.com/lilypond/lilypond/-/merge_requests/1019
> >
> >
> > Not sure why this one is still on Review? I hope
> > you don't mind I ask, it's just that I was hoping
> > for it to be included in the upcoming release.
>
> Hello Jean,
>
> I'm trying to follow James' practice of ensuring at least 24 hours of 
> review before moving to countdown.



Ah, I understand, but I think the practice is to
ensure 24 hours since the MR has been _created_,
the idea being that just the 48 hours of countdown
would be a bit short before merging the patch.
An MR that has seen recent _updates_ while having
been created earlier is fine (and this one is
2 months old :-).


> I agree that missing the window by 4 hours is a bit cautious on my 
> part; it comes from being the new kid, and also there seems to be an 
> unresolved thread in the MR.

Right, pinging there.

Best regards,
Jean