Re: Custom key signature stencils, differentiating major and minor keys

[Paul Morris]

On Nov 16, 2012, at 7:50 PM, Thomas Morley <address@hidden> wrote:

> 2012/11/14 Paul Morris <address@hidden>:
>> Hi Ming,  I took another look at this and since there's only one key
>> signature where the accidentals do not extend above the staff (F major / D
>> minor) I just added extra padding for those keys.  Now the key names always
>> appear above the staff, regardless of the clef.
>> 
>> The sizing of the accidental signs in the key names is better in this
>> version as well.
>> 
>> Cheers,
>> -Paul
> 
> Hi Paul,
> 
> am I right you've added your engraver to LSR with a [needs upgrade]-label?
> http://lsr.dsi.unimi.it/LSR/Item?u=1&id=856

Hi Harm,  Yes, that was me.


> If so:
> I downgraded your code to make it work with 2.14.2:
> changing the make-engraver-macro (created by David Kastrup) to the old
> syntax and changing the #{ #}-syntax (also made possible by David) to
> scheme-syntax.
> The 2.16.0-code is untouched and commented.

Thanks!  I didn't know that that was what was needed, or what changes to make.


> Note that I didn't have a closer look at the code. ;)

Ok. :)  I realize there may be better ways of doing it.  


> Also note, since there is something strange with the displayed
> LSR-output I added a markup to get the spacing correct.

Hmmm, ok.


> If you agree, I could approve it now.
> Currently, I let it unapproved, in case you may want to add or change sth.

I do have some small changes I made to my local copy that I'd like to add.  
They are for the accidental signs in the text -- better spacing and putting 
them into a LilyPond variable for less repetition.  I won't be able to get to 
this until Wednesday at the earliest. 

Thanks for your help getting it to run with 2.14.2!
-Paul