Re: changing the appearance for single dots in fret boards

[Thomas Morley]

2014-06-10 9:16 GMT+02:00 Marc Hohl <address@hidden>:
> Am 08.06.2014 02:49, schrieb Thomas Morley:
>
>> 2014-06-07 17:33 GMT+02:00 Marc Hohl <address@hidden>:
>>>
>>> Am 07.06.2014 10:02, schrieb Pierre Perol-Schneider:
>>>>
>>>>
>>>> 2014-06-06 9:59 GMT+02:00 Marc Hohl <address@hidden
>>>> <mailto:address@hidden>>:
>>>>
>>>>
>>>>      I have some fret diagrams where one dot is placed and removed
>>>> according
>>>>      to the underlying rhythm, so it would be great to either change its
>>>>      color or put it in parentheses.
>>>>
>>>>
>>>> Hallo Marc,
>>>> See discussion here :
>>>> http://www.lilypondforum.de/index.php?topic=1186.msg6498#msg6498
>>>
>>>
>>>
>>> Hi Pierre,
>>>
>>> thanks for the link! I wasn't aware of 'inverted' as an optional
>>> forth argument to place-fret. It looks as if this feature is
>>> not documented (it is used in
>>> input/regression/fret-diagrams-fingering.ly,
>>> though)
>>>
>>> What about the feature request and a possible patch for using
>>> 'parenthesized'? Is this still work-in-progress?
>>>
>>> I'm cc'ing to Harm, I think he knows best about the patch status.
>>
>>
>>
>> Hi Marc,
>>
>> yes I'm working on it.
>> http://code.google.com/p/lilypond/issues/detail?id=3930
>> is meant to prepare the final patch for
>> http://code.google.com/p/lilypond/issues/detail?id=2752
>> Though, it still needs some work before it does the job properly _and_
>> I'll have to add documentation about it.
>
>
> That's great – thanks for your work!
>
> Regards,
>
> Marc
>>
>>
>> Cheers,
>>    Harm
>>
>

First patch uploaded:

http://codereview.appspot.com/102450043

Cheers,
  Harm