Re: skylines and custom-code

[Jean Abou Samra]

Le 10/04/2021 à 10:34, Kevin Barry a écrit :
> On Sat, Apr 10, 2021 at 10:09:01AM +0200, Jean Abou Samra wrote:
> > > By the way, it looks like this issue is not present in 2.20...?
> > Sorry, I'm not following, what issue exactly?
> Harm's original issue with incorrect skylines. I ran his code through
> 2.20 and the skylines were fine. Something must have changed between
> 2.20 and 2.22?

Alright, my good old friend Git bisect says:

commit 0b45d764dcbc704713c8a32186561305e58d5659 (HEAD, refs/bisect/bad)
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Mon Apr 27 10:31:56 2020 +0200

    Add flag to NoteColumn using Axis_group_interface.

    The NoteColumn is an axis-group, for both X and Y axes.

    https://sourceforge.net/p/testlilyissues/issues/5945
    http://codereview.appspot.com/555770044

diff --git a/lily/rhythmic-column-engraver.cc 
b/lily/rhythmic-column-engraver.cc
index 189c99d551..f4e5b12dae 100644
--- a/lily/rhythmic-column-engraver.cc
+++ b/lily/rhythmic-column-engraver.cc
@@ -17,13 +17,14 @@
   along with LilyPond.  If not, see <http://www.gnu.org/licenses/>.
 */

+#include "axis-group-interface.hh"
+#include "dot-column.hh"
 #include "engraver.hh"
-#include "rhythmic-head.hh"
-#include "stem.hh"
-#include "note-column.hh"
 #include "item.hh"
-#include "dot-column.hh"
+#include "note-column.hh"
 #include "pointer-group-interface.hh"
+#include "rhythmic-head.hh"
+#include "stem.hh"

 #include "translator.icc"

@@ -105,7 +106,7 @@ Rhythmic_column_engraver::process_acknowledged ()

       if (flag_)
         {
-          Pointer_group_interface::add_grob (note_column_, 
ly_symbol2scm ("elements"), flag_);
+          Axis_group_interface::add_element (note_column_, flag_);
           flag_ = 0;
         }
     }


That makes sense to me: if flags are included in
the note column's extents, that may trigger skylines
earlier if the flag is looked at before the stem.

Best,
Jean