Re: [Linphone-developers] Purpose of linphone-1.99.0

[Simon Morlat]

I've decided to remove the gsmlib directory from next release.
As far as I know all distribs have now libgsm and libgsm-dev(el) packages.
GSM support will become optional.

Simon

Le Wednesday 31 October 2007 16:50:34 address@hidden, vous avez écrit :
> On Wed, Oct 31, 2007 at 03:31:30PM +0100, Francois-Xavier KOWALSKI wrote:
> > address@hidden wrote:
> >> I've compiled unstable/linphone-1.99.0 after some problems. I've met
> >> three pitfalls:
> >>
> >> 1) mediastreamer2/src/gsm.c includes <gsm/gsm.h> while -L../../libgsm.
> >> This
> >> leads into "gsm/gsm.h not found". Are you moving to external gsm
> >> library? This patch fixes it:
> >>
> >> diff -Naur linphone-1.99.0-org/mediastreamer2/src/gsm.c
> >> linphone-1.99.0/mediastreamer2/src/gsm.c
> >> --- linphone-1.99.0-org/mediastreamer2/src/gsm.c    2007-06-27
> >> 10:36:47.000000000 +0200
> >> +++ linphone-1.99.0/mediastreamer2/src/gsm.c    2007-10-28
> >> 22:59:33.000000000 +0100
> >> @@ -19,7 +19,7 @@
> >>
> >>  #include "mediastreamer2/msfilter.h"
> >>
> >> -#include <gsm/gsm.h>
> >> +#include <gsm.h>
> >
> > This one will break gsm support on Fedora/RedHat:
> >
> > % rpm -ql gsm-devel
>
> linphone containts its own libgsm under libgsm. If you investigate
> Makefile.am in mediastreamer2, you can see that library used for linking is
> library from linphone. Therefore if you have installed gsm-devel, header
> files are taken from /usr/include, but object file from linphone/libgsm.
> This is bad and should be fixed. Linphone should use header and object
> files from one location at one time.
>
> We can remove libgsm subdir from linphone's sources, create explicit check
> in configure.in for gsm-config and change mediastreamer2/Makefile.am to use
> system wide libgsm. (This is my favourite option.)
>
> Or we can use my patch (How does it break your system exactly? I have no
> system wide libgsm installed) to use internal implemetation only.
>
> Finaly we can make the location of libgsm library and header files compile
> time configurable via configure parameter.
>
> How do you vote?
>
> -- Petr