Re: [Linphone-developers] Two bugs in Linphone 3.0.0, one (apparent) fix

[Simon Morlat]

Hi Jim,

The two bugs you are refering are already fixed in the svn tree.
First one by replacing by 
linphone_gtk_call_terminated(linphone_gtk_get_main_window()); 
instead of 
 linphone_gtk_call_terminated(gtk_widget_get_toplevel(button));

checkout svn tree like this:
svn co svn://svn.savannah.nongnu.org/linphone/trunk linphone

and run ./autogen.sh to generate the configure script.

I'm sorry to admit that I should have made a new release for these bugfixes 
and many others since a long long time; unfortunately the 
december-january-february period was a no-life one for me so that I could not 
get the time to make the tarball and post  announcements.

I recommend everyone to use svn (I keep it stable).

Simon

Le Sunday 01 March 2009 17:20:01 Jim Diamond, vous avez écrit :
> Hi,
>
> (1) in gtk-glade/main.c, there is the code
>
> void linphone_gtk_decline_call(GtkWidget * button)
> {
>     linphone_core_terminate_call(linphone_gtk_get_core(), NULL);
>     linphone_gtk_call_terminated(gtk_widget_get_toplevel(button));
>     gtk_widget_destroy(gtk_widget_get_toplevel(button));
> }
>
> When someone calls, and you click the "Decline" button, the
>     linphone_gtk_call_terminated(gtk_widget_get_toplevel(button));
> statement causes an abort.  (I'm guessing that no linphone developer
> user ever declines a call; could this be true???)
>
> Commenting out this statement seems to work for me with no ill effects.
>
>
> (2) in coreapi/linphonecore.c there is the code
>
> static void linphone_core_disconnected(LinphoneCore * lc)
> {
>     lc->vtable.display_warning(lc, _("Remote end seems to have
> disconnected, the call is going to be closed."));
> linphone_core_terminate_call(lc, NULL);
> }
>
> There is a shortcoming here in that there is nothing to tell the GUI
> to change the "Terminate call" button back to "Start call".
> I think (maybe) we want something along the lines of
>     linphone_gtk_call_terminated(gtk_widget_get_toplevel(button));
> to be called there, but of course it is not that simple.
>
> I have not yet come to understand the code well enough to know the
> Right Way to do this.  I considered adding another entry to the vtable,
> and testing for / calling it from linphone_core_disconnected(), but
> I'm not sure if that is The Right Way To Do It or not.
>
> Comments/suggestions?
>
> Thanks.
>
>                               Jim
>
>
> _______________________________________________
> Linphone-developers mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/linphone-developers