Re: [Linphone-developers] Mediastreamer as external project with --enable-external-mediastreamer?

[Simon Brenner]

Hi again,

sorry, I forgot to mention that you first have to apply the patch and then you 
have to rename the
configure.in to configure.ac.

Regards,
-Simon.



On 09/22/2010 05:02 PM, Simon Brenner wrote:
> Hi Simon,
> 
> ok, I created a patch file with all the things I consider worth doing to 
> prepare this thing. Please
> have a careful look at everything and include it into mainline if you want to.
> 
> I created and tested my patch with a Linphone from git with the commit id
> 8210107a35463f30894027ad271ee0f66d79cb00 (22.09.2010).
> 
> Regards,
> -Simon
> 
> 
> 
> On 09/17/2010 09:28 AM, Simon Morlat wrote:
>> Hi Simon,
>>
>> There is no reason not to include this patch in mainline. This is of
>> interest for people packaging linphone, mediastreamer2 and oRTP in linux
>> distros.
>> Please send it and I'll merge it to master branch.
>>
>> Simon
>>
>> Le lundi 06 septembre 2010 à 12:00 +0200, Simon Brenner a écrit :
>>> Hi,
>>>
>>> the current linphone configure script offers the option 
>>> '--enable-external-ortp' so that it is
>>> possible to build/install the ortp package independently from the 
>>> 'linphone' one and make 'linphone'
>>> use the installed 'ortp' instead of the ortp subproject within the linphone 
>>> git repository.
>>>
>>> I was wondering whether the same is possible with the 'mediastreamer2' 
>>> project.
>>> Looking, for example, at the coreapi/Makefile.am I see a hard-coded include 
>>> path for mediastreamer2
>>> and linker path:
>>>
>>> INCLUDES = \
>>>     -I$(top_srcdir)\
>>>     -I$(top_srcdir)/mediastreamer2/include
>>>
>>> liblinphone_la_LIBADD= \
>>>             $(EXOSIP_LIBS) \
>>>             $(top_builddir)/mediastreamer2/src/libmediastreamer.la \
>>>             $(ORTP_LIBS)
>>>
>>> I actually tried myself to add a '--enable-external-mediastreamer' option 
>>> to the configure.in and
>>> replaced these hard-coded paths with the two variables 
>>> 'MEDIASTREAMER_CFLAGS' and
>>> 'MEDIASTREAMER_LIBS' and it actually worked as expected.
>>>
>>> Are there specific reasons not to include this in mainline?
>>>
>>> Thanks,
>>>
>>> -Simon.